fix(compose): migrate collectAsState to lifecycle-aware and fix state issues#835
Merged
Merged
Conversation
bmc08gt
commented
Jun 3, 2026
bmc08gt
commented
Collaborator
- Replace 18 collectAsState() calls with collectAsStateWithLifecycle() across 14 files to stop flow collection when backgrounded
- Fix var LocalSheetGesturesState to val to prevent accidental reassignment of the CompositionLocal reference
- Replace Timer() in TopBarContainer composition body with LaunchedEffect, preventing uncancelled timer creation on every recompose
- Replace SideEffect with LaunchedEffect(cameraPermission.status) in BillContainerView to prevent permission alert firing on every recompose
github-actions
Bot
added
type: fix
… issues - Replace 18 collectAsState() calls with collectAsStateWithLifecycle() across 14 files to stop flow collection when backgrounded - Fix var LocalSheetGesturesState to val to prevent accidental reassignment of the CompositionLocal reference - Replace Timer() in TopBarContainer composition body with LaunchedEffect, preventing uncancelled timer creation on every recompose - Replace SideEffect with LaunchedEffect(cameraPermission.status) in BillContainerView to prevent permission alert firing on every recompose
bmc08gt
force-pushed
the
fix/compose-lifecycle-state-correctness
branch
from
ae3c9ff to
4b4f189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.