fix(notifications): direct photo stream fallback when PHOTO_URI unavailable#846
Merged
Merged
Conversation
…ilable PhoneLookup.PHOTO_URI can be null when the contacts provider hasn't finished indexing a newly added contact's photo. Fall back to openContactPhotoInputStream which reads the raw photo blob by contact ID and doesn't depend on PHOTO_URI being populated. Also iterate all PhoneLookup rows instead of only the first, since linked contacts can return multiple rows where only one has a photo. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhoneLookup.PHOTO_URI can be null when the contacts provider hasn't finished indexing a newly added contact's photo. Fall back to openContactPhotoInputStream which reads the raw photo blob by contact ID and doesn't depend on PHOTO_URI being populated.
Also iterate all PhoneLookup rows instead of only the first, since linked contacts can return multiple rows where only one has a photo.