fix(compose): lazy list keys, stale remember, redundant derivedStateOf#851
Merged
Conversation
onConfirm was captured by a LaunchedEffect(Unit) without rememberUpdatedState. If the caller recomposes with a new lambda, the stale version executes on swipe-to-confirm.
Wrap sortedBy/groupBy, map, and forEachIndexed transforms in remember(key) so they do not re-run on every recomposition inside LazyColumn item factories.
Last remaining collectAsState() call in production code. Stops flow collection when the app is backgrounded.
Replace mutableStateOf(0L) with mutableLongStateOf(0L) to avoid Long autoboxing on every state read.
Replace Modifier.alpha(animatedFloat) and Modifier.rotate(animatedFloat) with graphicsLayer equivalents so animated values are read in the draw phase instead of triggering recomposition every frame.
…ection Replace LaunchedEffect(Unit) with LaunchedEffect(viewModel) so the effect restarts if the ViewModel instance changes, and is consistent across composables.
Add key parameters to items() calls in DeviceLogsScreen, UserFlagsEditor, FrequentlyUsedEmojis, and EmojiSearch so Compose can diff items correctly during recomposition instead of recomposing every item.
Replace remember with rememberSaveable for isExportSeedRequested and isStoragePermissionGranted so these flags survive configuration changes.
LocalAppUpdater and LocalCoinbaseOnRampController are provided once at app startup and never change. Using staticCompositionLocalOf avoids unnecessary recomposition tracking overhead.
Reorder parameters to follow Compose API guidelines: required params first, then modifier, then optional params, then trailing lambdas. Also fix modifier chain ordering in Pill and CodeToggleSwitch so the caller modifier is applied outermost.
Shared reusable component was missing a modifier parameter, preventing callers from controlling its layout.
LaunchedEffect(Unit) was reading state.customizations and state.purchaseAmount but only running once. Key on these values so the effect re-fires when they change.
… wrappers With Strong Skipping Mode enabled, the remember-based lambda caching in rememberedClickable is redundant — Compose auto-stabilizes lambdas. The Modifier.composed wrapper also allocates a sub-composition per element per recomposition. - Delete both rememberedClickable overloads from Modifier.kt - Rename rememberedLongClickable to longClickable (no composed) - Simplify noRippleClickable (no composed, null interactionSource) - Keep unboundedClickable (needs composed for @composable ripple()) - Migrate 38 call sites across the codebase: - Simple .rememberedClickable -> .clickable (standard foundation) - No-ripple pattern -> .noRippleClickable - Long click -> .longClickable - Remove unused MutableInteractionSource imports
…t derivedStateOf - Add stable `key` to lazy list items in TokenDetails and BackgroundControls - Remove redundant `derivedStateOf` wrappers where the block reads no snapshot State (NavigationBar, TransactionReceipt, TokenList) - Add missing `remember` keys to prevent stale cached values (LabsScreen, TokenDiscoveryScreen, Editors) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyto lazy listitems()inTokenDetails(social links) andBackgroundControls(color options grid)derivedStateOfwrappers where the block reads plain parameters instead of snapshotStateobjects (NavigationBar,TransactionReceipt,TokenList)rememberkeys to prevent stale cached values when inputs change (LabsScreen,TokenDiscoveryScreen,Editors— all three editor composables)8 files changed, 15 insertions, 28 deletions.
🤖 Generated with Claude Code