fix(cash): use relaxed timeout on exchange rate retry in GiveBillTransactor#899
Merged
Conversation
…sactor The retry path in start() resolved a fresh VerifiedState but still applied the strict billExchangeDataTimeout (30s) to it. When the server's rate timestamp was already >30s old (common after backgrounding), the freshly-fetched rate also failed the check. Now the retry passes null for billExchangeDataTimeout, falling back to the default 15-minute window. The initial check still uses the strict timeout — the relaxation only applies after we've just fetched fresh data via resolveVerifiedState. Closes: Bugsnag 6a1bd94017b0f7c09452ffd7 Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
area: network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry path in start() resolved a fresh VerifiedState but still applied the strict billExchangeDataTimeout to it. When the server's rate timestamp was already possibly older than timeout (common after backgrounding), the freshly-fetched rate also failed the check.
Now the retry passes null for billExchangeDataTimeout, falling back to the default 15-minute window. The initial check still uses the strict timeout — the relaxation only applies after we've just fetched fresh data via resolveVerifiedState.
Closes: Bugsnag 6a1bd94017b0f7c09452ffd7