fix(chat): improve event stream resilience and reduce churn#912
Merged
Conversation
bmc08gt
commented
Jun 16, 2026
bmc08gt
commented
Collaborator
- Guard openEventStream() to skip when already connected, preventing multiple callers (lifecycle, network, heartbeat) from tearing down a healthy stream
- Replace fixed 5s retry with exponential backoff (2s→60s cap)
- Switch from SharedFlow(DROP_OLDEST) to Channel(UNLIMITED) so no chat updates are silently dropped under load
- Coalesce applyUpdate into a single _state.update{} per ChatUpdate instead of up to 4 separate emissions
- Move syncFeed() side-effect out of state update lambda
- Only sync feed on heartbeat when stream is disconnected
- Guard openEventStream() to skip when already connected, preventing
multiple callers (lifecycle, network, heartbeat) from tearing down
a healthy stream
- Replace fixed 5s retry with exponential backoff (2s→60s cap)
- Switch from SharedFlow(DROP_OLDEST) to Channel(UNLIMITED) so no
chat updates are silently dropped under load
- Coalesce applyUpdate into a single _state.update{} per ChatUpdate
instead of up to 4 separate emissions
- Move syncFeed() side-effect out of state update lambda
- Only sync feed on heartbeat when stream is disconnected
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
area: network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.