fix: preserve Tistory article bodies#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the reader-mode extraction path for Tistory-style posts where Mozilla Readability can choose surrounding blog chrome instead of the article body. The fetcher now also keeps browser-shaped navigation headers without falling back to a bot-like retry identity.
Changes
undici.requestwith browser navigation headers, manual redirect handling, bounded body reads, and no Cloudflare challenge retry withpi-webfetchuser-agent.QA / Evidence
npx vitest --run test/webfetch.test.ts: 15 tests passed. Artifact:/Users/yeongyu/local-workspaces/senpi/.omo/evidence/webfetch-tistory-worktree-pr/external-verification-after-discard-fix.txt.npm run check:tsgo --noEmit && biome check .passed. Artifact:/Users/yeongyu/local-workspaces/senpi/.omo/evidence/webfetch-tistory-worktree-pr/external-verification-after-discard-fix.txt.another_category. Artifact:/Users/yeongyu/local-workspaces/senpi/.omo/evidence/webfetch-tistory-worktree-pr/external-live-tistory.txt.Risks
Secret safety
No secret-bearing logs, tokens, auth headers, cookies, or credentials are included in the evidence or PR body.
Summary by cubic
Fixes Tistory reader-mode by preferring real article containers and preserving line breaks, so posts no longer pick sidebar/category chrome. Also switches to browser-shaped fetching via
undici.requestfor more stable loads and safer redirects.undici.request, manual redirect handling, bounded body reads, and no bot-identity retry on Cloudflare challenges.Written for commit 83266e8. Summary will update on new commits.