Skip to content

V0.3.1/additional skills#5

Merged
gimlichael merged 16 commits intomainfrom
v0.3.1/additional-skills
Mar 19, 2026
Merged

V0.3.1/additional skills#5
gimlichael merged 16 commits intomainfrom
v0.3.1/additional-skills

Conversation

@gimlichael
Copy link
Member

This pull request updates documentation to require a stricter and more transparent benchmarking workflow for all repo-managed skills, and introduces three new skills with supporting documentation and usage examples. The most important changes are grouped below by theme.

Benchmarking and Evaluation Workflow Improvements:

  • All repo-managed skills must now be benchmarked from a temporary workspace using both with_skill and without_skill runs before work is considered complete. For new skills, the baseline is without_skill; for existing skills, it can be either without_skill or the previous/original version, matching the skill-creator benchmark flow. Human review of results via benchmark.json and eval-viewer/generate_review.py is now required, and generated artifacts must not be committed unless explicitly requested. These requirements are documented in README.md, CONTRIBUTING.md, and AGENTS.md. [1] [2] [3] [4]

New Skills Added and Documented:

  • Introduced three new skills: git-nuget-release-notes, git-nuget-readme, and skill-creator-agnostic. Each skill is now listed in the skills table and has a dedicated usage section in the README.md. [1] [2] [3]
  • Detailed descriptions and rationale for these new skills have been added, explaining their purpose and unique benefits for .NET and skill authoring workflows.

Skill Workflow and Validation Enhancements:

  • The documentation now emphasizes that validators (like scripts/validate-skill-templates.ps1) supplement, but do not replace, per-skill evals, and that validation includes checking for the presence of the benchmark workflow policy. [1] [2]

Improvements to Existing Skill Documentation:

  • The git-visual-commits documentation now clarifies that by default, all files in the worktree are committed and that mid-sentence wrapping in commit bodies is treated as a verification failure, with automatic repair.

These changes ensure a more rigorous, reviewable, and reproducible workflow for skill development and introduce new capabilities for .NET package documentation and benchmarking.

Create the NuGet release-notes skill with per-skill evals plus an extracted package release-notes format reference.

The skill targets .NET repos that keep cumulative .nuget/<ProjectName>/PackageReleaseNotes.txt files and turns git history into per-package release notes.
Make git-visual-commits treat short prose bodies that are wrapped mid-sentence as a verification failure that must be repaired before success is reported.

Add a targeted eval for repairing wrapped commit bodies while preserving bot identity and re-checking the stored message after amend.
Create a git-aware skill for writing package-facing NuGet READMEs from real project metadata, git history, and source-backed capability cues.

The skill keeps branding repo-derived, uses associated tests as supporting hints when feasible, and ships with per-skill evals plus a README blueprint reference.
Add a runner-agnostic overlay for Anthropic skill-creator so repo-managed skill work keeps temp-workspace isolation, valid benchmark layout, and honest measured-versus-simulated reporting across Codex, Copilot, and Opus.
Clarify that plain git bot commit requests apply to the entire worktree unless the user explicitly narrows scope. Add eval coverage so yolo mode still groups the full diff instead of silently committing only the latest task slice.
Document the mandatory with_skill versus without_skill benchmark flow for repo-managed skills and bring the README catalog up to date with the current skill set and commit-behavior guidance.
@gimlichael gimlichael self-assigned this Mar 18, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 21:04
@qodo-code-review
Copy link

Review Summary by Qodo

Add three new skills and enforce mandatory benchmarking workflow with human review

✨ Enhancement 📝 Documentation

Grey Divider

Walkthroughs

Description
• Add three new skills: git-nuget-release-notes, git-nuget-readme, and skill-creator-agnostic
  with full documentation and evals
• Enforce mandatory paired with_skill/without_skill benchmarking workflow for all repo-managed
  skills with human review via benchmark.json and eval-viewer
• Refactor git-visual-commits to treat full worktree as default scope and repair mid-sentence
  wrapped commit bodies before success
• Update documentation in AGENTS.md, CONTRIBUTING.md, and README.md to reflect stricter
  benchmarking requirements and new skills
Diagram
flowchart LR
  A["New Skills"] -->|git-nuget-release-notes| B["Per-package release notes"]
  A -->|git-nuget-readme| C["Package-facing README"]
  A -->|skill-creator-agnostic| D["Cross-runner benchmarking overlay"]
  E["Benchmarking Workflow"] -->|with_skill vs without_skill| F["Paired comparison"]
  F -->|aggregate_benchmark.py| G["benchmark.json"]
  G -->|generate_review.py| H["Human review artifact"]
  I["git-visual-commits Refactor"] -->|Full worktree default| J["Scope clarity"]
  I -->|Body repair| K["Mid-sentence wrap detection"]
Loading

Grey Divider

File Changes

1. AGENTS.md 📝 Documentation +14/-10

Mandatory paired benchmarking and human review workflow

AGENTS.md


2. CONTRIBUTING.md 📝 Documentation +12/-0

Add benchmarking checklist and paired comparison requirements

CONTRIBUTING.md


3. README.md 📝 Documentation +163/-84

Document new skills and update benchmarking guidance

README.md


View more (12)
4. skills/git-nuget-release-notes/SKILL.md ✨ Enhancement +252/-0

New skill for per-package NuGet release notes

skills/git-nuget-release-notes/SKILL.md


5. skills/git-nuget-release-notes/evals/evals.json 🧪 Tests +63/-0

Evals for git-nuget-release-notes skill

skills/git-nuget-release-notes/evals/evals.json


6. skills/git-nuget-release-notes/references/package-release-notes-format.md 📝 Documentation +116/-0

Reference blueprint for package release notes format

skills/git-nuget-release-notes/references/package-release-notes-format.md


7. skills/git-nuget-readme/SKILL.md ✨ Enhancement +255/-0

New skill for package-facing NuGet README

skills/git-nuget-readme/SKILL.md


8. skills/git-nuget-readme/evals/evals.json 🧪 Tests +69/-0

Evals for git-nuget-readme skill

skills/git-nuget-readme/evals/evals.json


9. skills/git-nuget-readme/references/nuget-readme-blueprint.md 📝 Documentation +209/-0

Reference blueprint for NuGet README structure

skills/git-nuget-readme/references/nuget-readme-blueprint.md


10. skills/git-visual-commits/SKILL.md ✨ Enhancement +78/-24

Clarify full worktree default scope and body repair rules

skills/git-visual-commits/SKILL.md


11. skills/git-visual-commits/evals/evals.json 🧪 Tests +22/-0

Add evals for full worktree scope and body repair

skills/git-visual-commits/evals/evals.json


12. skills/skill-creator-agnostic/SKILL.md ✨ Enhancement +232/-0

New runner-agnostic skill-creator overlay skill

skills/skill-creator-agnostic/SKILL.md


13. skills/skill-creator-agnostic/evals/evals.json 🧪 Tests +62/-0

Evals for skill-creator-agnostic skill

skills/skill-creator-agnostic/evals/evals.json


14. skills/skill-creator-agnostic/references/benchmark-contract.md 📝 Documentation +160/-0

Reference for benchmark workspace layout and contract

skills/skill-creator-agnostic/references/benchmark-contract.md


15. skills/skill-creator-agnostic/references/windows-powershell-benchmarking.md 📝 Documentation +69/-0

Reference for Windows PowerShell benchmarking pitfalls

skills/skill-creator-agnostic/references/windows-powershell-benchmarking.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 18, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider


Action required

1. `` in YAML frontmatter📘 Rule violation ✓ Correctness
Description
The SKILL.md frontmatter includes angle brackets via .nuget//..., which is disallowed inside YAML
frontmatter. This can break downstream frontmatter parsers and violates the repo’s frontmatter
restrictions.
Code

skills/git-nuget-release-notes/SKILL.md[R4-6]

+  Create or update per-package NuGet release notes from git history for
+  .NET repositories that store cumulative
+  `.nuget/<ProjectName>/PackageReleaseNotes.txt` files. Use this skill
Evidence
PR Compliance ID 111410 forbids any `` characters anywhere inside SKILL.md YAML frontmatter. The new
description value includes .nuget//PackageReleaseNotes.txt within the frontmatter block.

Rule 111410: Disallow angle brackets in SKILL.md YAML frontmatter
skills/git-nuget-release-notes/SKILL.md[4-6]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`skills/git-nuget-release-notes/SKILL.md` YAML frontmatter contains angle brackets (`&amp;lt;`/`&amp;gt;`), which are disallowed.
## Issue Context
The frontmatter `description` currently uses a placeholder path `.nuget/&amp;lt;ProjectName&amp;gt;/PackageReleaseNotes.txt`. Per compliance, placeholders in frontmatter must not use angle brackets.
## Fix Focus Areas
- skills/git-nuget-release-notes/SKILL.md[1-17]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. `` in YAML frontmatter📘 Rule violation ✓ Correctness
Description
The SKILL.md frontmatter includes angle brackets via eval-N//run-N/, which is disallowed inside
YAML frontmatter. This can break strict frontmatter consumers and violates the repo’s frontmatter
restrictions.
Code

skills/skill-creator-agnostic/SKILL.md[R5-9]

+  for creating, modifying, and benchmarking skills across Codex, GitHub
+  Copilot, Opus, and similar agents. Use whenever skill work must
+  follow temp-workspace isolation, valid `eval-N/<config>/run-N/`
+  benchmark layout, honest measured-vs-simulated labeling, UTF-8-safe
+  artifact generation, and repo-managed skill sync/README update rules.
Evidence
PR Compliance ID 111410 prohibits `` anywhere in SKILL.md YAML frontmatter. The newly added
frontmatter description contains eval-N//run-N/ which includes angle brackets.

Rule 111410: Disallow angle brackets in SKILL.md YAML frontmatter
skills/skill-creator-agnostic/SKILL.md[5-9]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`skills/skill-creator-agnostic/SKILL.md` YAML frontmatter contains angle brackets (`&amp;lt;`/`&amp;gt;`), which are disallowed.
## Issue Context
The frontmatter `description` includes `eval-N/&amp;lt;config&amp;gt;/run-N/` as a placeholder path. The same placeholder guidance can be expressed without angle brackets (e.g., `{config}`) or moved into the Markdown body.
## Fix Focus Areas
- skills/skill-creator-agnostic/SKILL.md[1-14]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. Agnostic skill missing ## Critical📘 Rule violation ⚙ Maintainability
Description
This SKILL.md uses ## Non-Negotiable Rules for critical instructions instead of the required `##
Critical or ## Important` header. This violates the mandated header naming/placement for critical
instructions.
Code

skills/skill-creator-agnostic/SKILL.md[R28-35]

+## Non-Negotiable Rules
+
+- Start from Anthropic's `skill-creator` workflow. Use this skill to add
+  environment and repo guardrails, not to fork or replace the upstream
+  skill.
+- Do not edit third-party skills such as Anthropic's `skill-creator` to
+  encode repo-specific behavior. Keep those rules in repo-managed files
+  and companion skills instead.
Evidence
PR Compliance ID 111429 mandates that critical instruction blocks use an H2 header exactly `##
Critical or ## Important. The new skill groups critical rules under ## Non-Negotiable Rules`
instead.

Rule 111429: Place critical instructions at the top of SKILL.md with specific headers
skills/skill-creator-agnostic/SKILL.md[28-35]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Critical instructions are under `## Non-Negotiable Rules` instead of the required `## Critical`/`## Important` header.
## Issue Context
This section contains mandatory constraints (e.g., not editing third-party skills, temp workspace requirements, sync rules). Compliance requires critical instructions to be placed at the top and labeled with the exact H2 header `## Critical` or `## Important`.
## Fix Focus Areas
- skills/skill-creator-agnostic/SKILL.md[16-58]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

4. Validator claim misleading🐞 Bug ⚙ Maintainability
Description
README.md now claims scripts/validate-skill-templates.ps1 checks for the repo’s benchmark-workflow
policy in docs, but the validator only enforces per-skill evals.json and frontmatter description
length. This can mislead contributors into thinking CI enforces the documented benchmark workflow
when it currently does not.
Code

README.md[R17-21]

Validation follows the same philosophy: run
`scripts/validate-skill-templates.ps1` locally for the fast feedback
loop, and let GitHub Actions rerun that same script on pull requests as
the safety net. That validator also checks skill frontmatter metadata
-such as the 1024-character YAML description limit.
-
+such as the 1024-character YAML description limit and the presence of the repo's benchmark-workflow policy in the expected docs.
Evidence
README asserts the validator checks for presence of a benchmark-workflow policy in docs, but the
validator’s implemented checks in scripts/validate-skill-templates.ps1 (as currently written) cover
evals/evals.json validity and YAML frontmatter description length, with no corresponding doc-policy
validation.

README.md[17-21]
scripts/validate-skill-templates.ps1[256-319]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`README.md` states that `scripts/validate-skill-templates.ps1` checks for the presence of the repo’s benchmark-workflow policy in the expected docs, but the validator script does not currently implement such a check.
## Issue Context
This creates false confidence about what CI enforces. Either the validator must be extended to enforce the policy, or the README must stop claiming it does.
## Fix Focus Areas
- README.md[17-21]
- scripts/validate-skill-templates.ps1[256-319]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


5. Benchmark tool path unclear🐞 Bug ⚙ Maintainability
Description
Repo-level docs require using eval-viewer/generate_review.py (and producing benchmark.json) but
don’t clearly say these scripts come from the Anthropic skill-creator install or provide the
expected paths. This inconsistency makes the new mandatory workflow harder to follow than the repo’s
own benchmark-contract reference.
Code

README.md[R11-13]

Another repo rule is intentionally strict: every repo-managed skill ships with its own `evals/evals.json`, and those evals are run per skill from a temp workspace instead of from inside this repository.

-There is also an interim Codex compatibility workaround in [AGENTS.md](AGENTS.md): the repo mirrors the current `~/.codex/AGENTS.override.md` decision and code-change rules so they still apply even when a Codex build fails to auto-load that personal override file.
+Another part of that workflow is now mandatory too: when a repo-managed skill is created or modified, the author must run both `with_skill` and `without_skill` comparison executions from a temp workspace, aggregate the results into `benchmark.json`, and open `eval-viewer/generate_review.py` so a human can review both the `Outputs` and `Benchmark` views before sign-off. For new skills the baseline is `without_skill`; for existing skills it can be `without_skill` or the previous/original skill version, matching the `skill-creator` benchmark flow.
Evidence
README/AGENTS/CONTRIBUTING reference eval-viewer/generate_review.py as if it were locally
available, while the repo’s own benchmark-contract reference shows the intended fully qualified
location under $HOME/.agents/skills/skill-creator/..., implying the top-level docs are missing
required discovery context.

README.md[11-13]
AGENTS.md[20-33]
CONTRIBUTING.md[92-100]
skills/skill-creator-agnostic/references/benchmark-contract.md[142-156]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Top-level docs mandate running `eval-viewer/generate_review.py` and generating `benchmark.json`, but they don’t specify where those scripts live (they are part of the Anthropic `skill-creator` install). This makes the required workflow ambiguous for contributors.
## Issue Context
The repo already contains the correct fully qualified example paths in `skills/skill-creator-agnostic/references/benchmark-contract.md`; the repo-level docs should match that level of clarity.
## Fix Focus Areas
- README.md[11-13]
- AGENTS.md[24-30]
- CONTRIBUTING.md[92-100]
- skills/skill-creator-agnostic/references/benchmark-contract.md[142-156]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the documented benchmarking/evaluation workflow for repo-managed skills (paired with_skill/without_skill runs from a temp workspace with human review via benchmark.json + eval viewer), and adds three new skills with supporting references and eval definitions.

Changes:

  • Document stricter benchmark workflow requirements across README.md, CONTRIBUTING.md, and AGENTS.md.
  • Add new skills: git-nuget-release-notes, git-nuget-readme, and skill-creator-agnostic (each with SKILL.md, references, and per-skill evals).
  • Expand git-visual-commits guidance and evals around default scope and commit-body verification/repair.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
skills/skill-creator-agnostic/SKILL.md New skill overlay documenting runner-agnostic skill creation/benchmark guardrails.
skills/skill-creator-agnostic/references/windows-powershell-benchmarking.md New Windows/PowerShell benchmark hygiene reference (encoding, paths, etc.).
skills/skill-creator-agnostic/references/benchmark-contract.md New benchmark artifact/layout contract reference for reproducible runs.
skills/skill-creator-agnostic/evals/evals.json New per-skill eval prompts/expectations for the overlay skill.
skills/git-visual-commits/SKILL.md Clarifies default full-worktree scope and commit-body wrap verification/repair behavior.
skills/git-visual-commits/evals/evals.json Adds evals covering mid-sentence wrap repair and full-worktree default scope in yolo mode.
skills/git-nuget-release-notes/SKILL.md New skill for generating per-package PackageReleaseNotes.txt from git + project metadata.
skills/git-nuget-release-notes/references/package-release-notes-format.md New reference blueprint for the normalized PackageReleaseNotes format/sections.
skills/git-nuget-release-notes/evals/evals.json New per-skill eval prompts/expectations for release-notes generation behavior.
skills/git-nuget-readme/SKILL.md New skill for updating NuGet-facing README.md grounded in git + metadata + source/tests.
skills/git-nuget-readme/references/nuget-readme-blueprint.md New reference blueprint for a NuGet adoption-focused README structure/tone.
skills/git-nuget-readme/evals/evals.json New per-skill eval prompts/expectations for README update behavior.
README.md Documents new benchmark workflow requirements and lists/introduces the new skills.
CONTRIBUTING.md Adds paired benchmark + human review requirements to contribution guidance/checklist.
AGENTS.md Reinforces temp-workspace eval execution + paired benchmarking + artifact review guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md Outdated
Comment on lines +17 to +21
Validation follows the same philosophy: run
`scripts/validate-skill-templates.ps1` locally for the fast feedback
loop, and let GitHub Actions rerun that same script on pull requests as
the safety net. That validator also checks skill frontmatter metadata
such as the 1024-character YAML description limit.
such as the 1024-character YAML description limit and the presence of the repo's benchmark-workflow policy in the expected docs.
Comment on lines +4 to +9
Adds runner-agnostic guardrails on top of Anthropic's skill-creator
for creating, modifying, and benchmarking skills across Codex, GitHub
Copilot, Opus, and similar agents. Use whenever skill work must
follow temp-workspace isolation, valid `eval-N/<config>/run-N/`
benchmark layout, honest measured-vs-simulated labeling, UTF-8-safe
artifact generation, and repo-managed skill sync/README update rules.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d2e6e78fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Typical flow:

```powershell
python "$HOME/.agents/skills/skill-creator/scripts/aggregate_benchmark.py" `

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Parameterize skill-creator script paths in benchmark commands

These command examples hard-code "$HOME/.agents/skills/skill-creator/...", which breaks the advertised runner-/environment-agnostic workflow when skill-creator is installed elsewhere (for example only under ~/.claude/skills or a system path). In those setups the documented aggregation/review steps fail with file-not-found, so users cannot produce benchmark.json/review artifacts even if their benchmark layout is correct; use a discovered skill path (or an explicit variable) instead of a fixed install location.

Useful? React with 👍 / 👎.

aicia-bot and others added 10 commits March 19, 2026 18:33
Standardizes documentation across AGENTS.md, CONTRIBUTING.md, and README.md to explicitly instruct users to resolve the installed Anthropic skill-creator path (typically under ~/.agents/skills/skill-creator/ or ~/.claude/skills/skill-creator/) before running benchmark and review tools. Replaces implicit path assumptions with explicit resolver guidance to support both local install locations.
Corrects placeholder syntax from <ProjectName> to {ProjectName} for proper YAML semantics throughout the skill documentation. Renames 'Non-Negotiable Rules' section to 'Critical' for consistency with other repo-managed skills and improved clarity of critical requirements.
Updates benchmark directory pattern from eval-N to iteration-N/eval-name/{config}/run-N/ for clarity and consistency. Adds PowerShell resolver logic to benchmark-contract.md that probes ~/.agents/skills/skill-creator/ and ~/.claude/skills/skill-creator/, then runs benchmark and review scripts from the resolved root. Updates SKILL.md to clarify that users must resolve the installed skill-creator path before calling benchmark tools. Renames 'Non-Negotiable Rules' to 'Critical' for consistency across repo skills.
Rewraps long lines in AGENTS.md, CONTRIBUTING.md, CHANGELOG.md, and README.md for improved readability and consistent line length. Removes extra blank lines and normalizes list formatting across repo governance and policy documents.
Normalizes line wrapping and formatting across all SKILL.md, FORMS.md, and references/ files. Compacts multi-line YAML descriptions and removes extra blank lines for consistent documentation presentation. Improves readability while preserving all content and functional meaning.
Normalizes line wrapping in shared asset templates including .github/copilot-instructions.md, asset CHANGELOG.md bootstrap files, and nuget-readme.md package documentation templates. Removes extra blank lines and improves readability while preserving all content.
Adds the v0.3.1 release entry (2026-03-19) documenting three new skills (git-nuget-release-notes, git-nuget-readme, skill-creator-agnostic) and seven key improvements to git-visual-commits, benchmark tooling, skill formatting, and repo documentation. Updates compare links to reflect the new release version and keeps the Unreleased placeholder ready for future work.
Adds explicit support for release-intent trigger words (finalize, release, publish, ship) that automatically extract and use the version from version-prefixed branch names (e.g., v0.3.1/additional-skills becomes 0.3.1). Updates skill description to advertise the new triggers and clarifies Step 2 workflow to prioritize release-intent words when determining changelog target section. This streamlines release finalization by eliminating the need to manually specify versions.
Condenses the skill description from 1044 to 667 characters to comply with the repo's 1024-character limit while preserving all trigger phrases (finalize, ready to release, rtr, release) and key capabilities. Tightens wording without losing clarity about when to use the skill or what it does.
Completes the v0.3.1 release entry with curated narrative highlighting three new NuGet-focused skills (git-nuget-release-notes, git-nuget-readme, skill-creator-agnostic) and eight key improvements to repo automation, documentation standards, and skill refinements. Release classified as patch (docs, formatting, skill improvements; no breaking changes).
@gimlichael gimlichael merged commit f3e0593 into main Mar 19, 2026
1 check passed
@gimlichael gimlichael deleted the v0.3.1/additional-skills branch March 19, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants