feat: add approval threshold to GroupTreasuryContract initialization …#201
Open
samieazubike wants to merge 1 commit into
Open
feat: add approval threshold to GroupTreasuryContract initialization …#201samieazubike wants to merge 1 commit into
samieazubike wants to merge 1 commit into
Conversation
…and implement related tests
|
@samieazubike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and implement related tests
Description
Add approval threshold + withdraw-proposal storage to group_treasury (closes #121)
Scaffolds the storage and initialize changes for the upcoming multisig withdrawal flow.
Verified: cargo test -p group_treasury (20 passed) and cargo build -p group_treasury --target wasm32-unknown-unknown --release (confirms no_std compile).
Note: initialize enforces threshold ≥ 1 only - the "≤ member count" rule isn't checkable at init since the members list starts empty, so it's deferred to the proposal-lifecycle issues.
Type of change
Checklist