Add unit tests for POST /index/message (Close #148)#203
Open
ciscokwiz wants to merge 2 commits into
Open
Conversation
Centralize admin check and update backend configuration
- 7 tests covering all paths: connection failure, collection creation, insert vs replace branching, close on success/error, and missing fields validation - Closes codebestia#148
|
@ciscokwiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 pytest unit tests for the
POST /index/messageendpoint inapps/ai_agent/main.py, covering all code paths including error handling and resource cleanup.Closes #148
Tests
test_weaviate_connection_failure_returns_503test_creates_collection_if_missingMessagecollection auto-created when absenttest_inserts_new_messagecollection.data.insertcalled,replacenot calledtest_replaces_existing_messagecollection.data.replacecalled,insertnot calledtest_closes_weaviate_on_successclient.close()called after successful requesttest_closes_weaviate_on_errorclient.close()called infinallyblock on exceptiontest_missing_fields_returns_422Verification
All 7 tests pass:
Notes
pytestandhttpxare required only as dev dependencies.insertvsreplace) tested independently withassert_called_once/assert_not_called.