feat: revoke (unlink) device via DELETE /devices/:id#210
Open
Andreschuks101 wants to merge 1 commit into
Open
Conversation
|
@Andreschuks101 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revoke (unlink) a device — DELETE /devices/:id
closes #157
Soft-revokes a device and tears down all of its access across the cluster.
Changes
devices(revokedAt,publicKey,lastSeenAt) anddevice_prekeystables, relations, types, and migration0007_device_revocation.DELETE /devices/:id: stampsrevokedAt, deletes the device's prekeys,disconnects its live sockets, publishes
device_revokedon the Redis bus, andemits a
key_changenotice to peers in shared conversations.GET /devices: lists the caller's devices.device" rule is enforced atomically inside the UPDATE so concurrent revokes
cannot remove a user's final device.
foreign device is refused at connection time, excluding it from future fan-out.
A Redis bus subscriber tears down device sockets on every instance.
Behaviour / acceptance criteria
revokedAtset; prekeys removed; live sockets disconnected.key_changeevent.Testing
last-device 409, success path, concurrent-revoke race, socket disconnect, peer
notification, bus publish).
Notes
deviceIdin the Socket.IO handshake auth to bind a socket to a device.