feat(keycloakx): add namespaceOverride and service.internalTrafficPolicy#909
Open
teddy0605 wants to merge 1 commit into
Open
Conversation
Adds a `namespaceOverride` value that lets umbrella charts deploy multiple aliased keycloakx instances each into their own namespace. A new `keycloakx.namespace` helper template centralises the logic and is used in place of `.Release.Namespace` across all resource templates. Adds `service.internalTrafficPolicy` to values.yaml and wires it into service-http.yaml so callers no longer need a post-renderer workaround to set this field. Signed-off-by: teddy0605 <teddy0605@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespaceOverridevalue so umbrella charts can deploy multiple aliased keycloakx instances each into their own namespace. Akeycloakx.namespacehelper centralises the logic; all templates use it instead of.Release.Namespacedirectly.service.internalTrafficPolicytovalues.yamlandservice-http.yaml. Previously there was no way to set this field without a post-renderer workaround.Motivation
When deploying keycloakx as a subchart multiple times in the same umbrella chart (using Helm aliases), all instances land in the release namespace.
namespaceOverridelets each alias target a different namespace independently.internalTrafficPolicyis needed to control routing for internal cluster traffic (e.g.Localto keep traffic node-local), which is a standard Kubernetes Service field not currently exposed by the chart.Backwards compatibility
Both changes are additive. Default values (
namespaceOverride: "",internalTrafficPolicy: "") preserve existing behaviour — charts that don't set these values render identically to before.