feat: detect unfocused element before type() and pressKey()#5500
Merged
feat: detect unfocused element before type() and pressKey()#5500
Conversation
…ent is focused type() sends keystrokes via page.keyboard which silently drops input when no element has focus. Add a shared checkFocusBeforeType() that warns in debug mode and throws NonFocusedType in strict mode. Applied to Playwright, Puppeteer, and WebDriver helpers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NonFocusedType now accepts message from caller. checkFocusBeforePressKey() warns/throws only for editing key combos (Ctrl/Meta + A/C/X/V/Z/Y), not for navigation keys like Escape or Tab. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DavertMik
changed the title
WebDriver's getNormalizedKey converts key names to Unicode code points, so checking after normalization misses the modifier. Now check the original user-provided key array before any normalization happens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type()andpressKey()usepage.keyboardwhich silently drops keystrokes when no element has focus. This adds shared focus checks inlib/helper/extras/focusCheck.js:type(): always checks focus before typingpressKey(): checks focus only for editing combos: Ctrl/Meta + A, C, X, V, Z, Y (handlesCommandOrControl→Metaon macOS)debugSectionstrict: true): throwsNonFocusedTypeerror with actionable message<body contenteditable>(full-page editors) — no false positiveTest plan
NonFocusedTypewhen typing without focusNonFocusedTypefor Ctrl+A without focus🤖 Generated with Claude Code