fix: getComponents .map is not a function TypeError - #158
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
TypeError: (intermediate value)(intermediate value)(intermediate value).map is not a functionoccurring in thegetComponentsfunction withinsrc/content/github/common/fetchers.ts.The root cause was that
getComponentswas attempting to call.map()directly on theresponse.dataobject, which for the components API endpoint, is a paginated response of the form{results: [...], count: N}. Therefore,response.datawas an object, not an array, leading to the TypeError.The fix involves changing
response.datatoresponse.data.resultson line 38 ofsrc/content/github/common/fetchers.ts. This ensures that the.map()function is called on the actual array of components, consistent with how thegetFlagsfunction in the same file handles similar paginated API responses.Fixes BROWSER-EXTENSION-1K