Skip to content

Prefer Codecov GitHub app over Sentry app for Sentry-linked orgs#1024

Open
thomasrockhu-codecov wants to merge 2 commits into
mainfrom
th/prefer-codecov-github-app
Open

Prefer Codecov GitHub app over Sentry app for Sentry-linked orgs#1024
thomasrockhu-codecov wants to merge 2 commits into
mainfrom
th/prefer-codecov-github-app

Conversation

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

Summary

  • Prefer the Codecov GitHub app over the Sentry app when a Sentry-linked org has multiple GitHub apps installed. The Codecov app is now the primary selection, with the Sentry app retained as a fallback for availability.

Details

  • libs/shared/shared/bots/github_apps.py: removed the override that forced Sentry-linked owners onto the Sentry app, and added the Sentry app as a fallback in the weighted-selection path.
  • libs/shared/tests/unit/bots/test_github_apps.py: updated/added tests covering Codecov-preferred selection and Sentry fallback (including the Sentry-only org case).

Test plan

  • pytest libs/shared/tests/unit/bots/ (36 passed)
  • CI green

Made with Cursor

For orgs with multiple GitHub apps, app selection previously overrode the
primary app to the Sentry app. Now the Codecov app is preferred, with the
Sentry app retained as a fallback for availability.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 5, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing th/prefer-codecov-github-app (31b6b33) with main (945f22d)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (508927b) during the generation of this report, so 945f22d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sentry
Copy link
Copy Markdown
Contributor

sentry Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (508927b) to head (31b6b33).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files        1318     1318           
  Lines       50711    50712    +1     
  Branches     1625     1625           
=======================================
+ Hits        46604    46605    +1     
  Misses       3801     3801           
  Partials      306      306           
Flag Coverage Δ
apiunit 94.96% <ø> (ø)
sharedintegration 36.94% <0.00%> (-0.01%) ⬇️
sharedunit 84.91% <100.00%> (+<0.01%) ⬆️
workerintegration 58.56% <ø> (ø)
workerunit 90.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant