Prefer Codecov GitHub app over Sentry app for Sentry-linked orgs#1024
Open
thomasrockhu-codecov wants to merge 2 commits into
Open
Prefer Codecov GitHub app over Sentry app for Sentry-linked orgs#1024thomasrockhu-codecov wants to merge 2 commits into
thomasrockhu-codecov wants to merge 2 commits into
Conversation
For orgs with multiple GitHub apps, app selection previously overrode the primary app to the Sentry app. Now the Codecov app is preferred, with the Sentry app retained as a fallback for availability.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 1318 1318
Lines 50711 50712 +1
Branches 1625 1625
=======================================
+ Hits 46604 46605 +1
Misses 3801 3801
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
libs/shared/shared/bots/github_apps.py: removed the override that forced Sentry-linked owners onto the Sentry app, and added the Sentry app as a fallback in the weighted-selection path.libs/shared/tests/unit/bots/test_github_apps.py: updated/added tests covering Codecov-preferred selection and Sentry fallback (including the Sentry-only org case).Test plan
pytest libs/shared/tests/unit/bots/(36 passed)Made with Cursor