fix(worker): N+1 Query in ProcessFlakesTask#1028
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 1318 1318
Lines 50711 50715 +4
Branches 1625 1625
=======================================
+ Hits 46604 46608 +4
Misses 3801 3801
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue in the
app.tasks.flakes.ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction.Problem:
Previously,
process_flakes_for_commititerated over eachuploadand calledprocess_single_upload. Insideprocess_single_upload,get_testrunswould perform aSELECTquery for that specific upload, and thenTestrun.objects.bulk_updatewould perform anUPDATEquery for the testruns associated with that upload. This resulted in 2N database queries (N SELECTs + N UPDATEs) where N is the number of uploads for a given commit.Solution:
get_testruns: It now accepts a list ofupload_idsand fetches all relevant testruns in a singleSELECTquery usingupload_id__in.process_flakes_for_commit, all testruns for all uploads are fetched once at the beginning.process_single_upload: This function now receives the pre-fetched testruns relevant to its specific upload, eliminating its internalSELECTcall.bulk_update: All modified testruns are collected, and a singleTestrun.objects.bulk_updateis performed after the loop, updating all outcomes in one go.Benefit:
This change reduces the database queries from 2N to a constant 2 (one batched SELECT and one batched UPDATE), significantly improving performance for commits with many uploads.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YQ5