fix(N+1): Batch fetch testruns in ProcessFlakesTask#1029
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 1318 1318
Lines 50711 50714 +3
Branches 1625 1625
=======================================
+ Hits 46604 46607 +3
Misses 3801 3801
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in the
app.tasks.flakes.ProcessFlakesTask, specifically within theprocess_flakes_for_commitfunction inapps/worker/services/test_analytics/ta_process_flakes.py.Problem:
The
process_flakes_for_commitfunction iterated over a list ofuploadsand, for eachupload, calledprocess_single_upload. Insideprocess_single_upload,get_testruns(upload)was invoked, which executed a separate database query to fetch testruns for that specific upload. This resulted in1 + Ndatabase queries (1 for uploads, N for testruns) for each commit being processed.Solution:
To eliminate the N+1 query, the following changes were implemented:
get_testruns_for_uploads, was introduced to fetch all relevant testruns for a list ofupload_idsin a single batched database query. The results are then grouped byupload_id.process_single_uploadfunction was refactored to accept a pre-fetched list ofTestrunobjects directly, removing its internal database call.process_flakes_for_commit,uploadsare now evaluated to a list, andget_testruns_for_uploadsis called once with allupload_ids. The grouped testruns are then passed toprocess_single_uploadwithin the loop.get_testrunsfunction and an unusedQuerySetimport were removed.This change reduces the database query count from
1 + Nto a constant2queries per commit, significantly improving performance for commits with many associated uploads.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YQ6