fix(bundle_analysis): auto-create repository on org-token upload#1030
Open
sentry[bot] wants to merge 1 commit into
Open
fix(bundle_analysis): auto-create repository on org-token upload#1030sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 91.90% 91.89% -0.01%
==========================================
Files 1318 1318
Lines 50711 50726 +15
Branches 1625 1625
==========================================
+ Hits 46604 46616 +12
- Misses 3801 3804 +3
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (82.35%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue API-E90, where bundle analysis uploads failed with a "NotFound: Repository not found." error when using an organization-level token for a repository that had not yet been registered in Codecov's database.
The root cause was that the
get_repository_from_stringhelper, used for org-token uploads, performed a strictRepository.objects.get(), which would fail if the repository did not exist. Unlike repository-level token uploads, org-level token uploads did not have a mechanism to automatically register new repositories.This fix introduces a new helper function,
get_or_create_repository_from_string, which usesRepository.objects.get_or_create()to ensure that a repository record exists. If the repository is not found, it is automatically created with default values (private=False,active=False,activated=False). This new helper is now used specifically in the_handle_uploadmethod of theBundleAnalysisViewwhen anOwner(org-level token) is performing the upload.Additionally, a log message is added to indicate when a repository is auto-created, improving observability.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes API-E90