fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1033
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): Eliminate N+1 queries in ProcessFlakesTask#1033sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 91.90% 91.89% -0.01%
==========================================
Files 1318 1318
Lines 50711 50720 +9
Branches 1625 1625
==========================================
+ Hits 46604 46611 +7
- Misses 3801 3803 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query issue identified in
app.tasks.flakes.ProcessFlakesTask.Problem:
Previously, the
ProcessFlakesTaskwas inefficiently querying the database in two main areas:fetch_current_flakes(repo_id)was called insideprocess_flakes_for_commitfor every commit being processed. Since therepo_idis constant for all commits within a single task execution, this resulted in N identical queries to fetch the same set of flakes.get_testruns(upload)was called for each individual upload withinprocess_single_upload, leading to M separate queries for testruns associated with a commit's uploads.This pattern led to a high number of database queries, impacting performance.
Solution:
fetch_current_flakes: The call tofetch_current_flakes(repo_id)has been moved fromprocess_flakes_for_committoprocess_flakes_for_repo. This ensures that the current flakes for a given repository are fetched only once perProcessFlakesTaskexecution, and the resultingcurr_flakesdictionary is passed down toprocess_flakes_for_commitandprocess_single_upload.get_testruns_for_uploads, was introduced to fetch all relevant testruns for a list of uploads in a single database query usingupload_id__in. Theprocess_single_uploadfunction was updated to accept these pre-fetched testruns, eliminating the per-upload query.Testrun.objects.bulk_updatecall, which was previously executed per upload, is now consolidated into a single call at the end ofprocess_flakes_for_commitfor all modified testruns related to a commit.Impact:
These changes significantly reduce the number of database queries executed by
ProcessFlakesTask, improving its efficiency and reducing database load. The flake fetching is now O(1) per task, and testrun fetching is O(1) per commit (instead of O(N commits) and O(N commits * M uploads) respectively).Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes WORKER-YQ9