Skip to content

fix(sentry): ignore GraphQL client validation errors#1034

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/sentry-graphql-validation
Open

fix(sentry): ignore GraphQL client validation errors#1034
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/sentry-graphql-validation

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Jun 7, 2026

Problem

GraphQL validation errors, such as GraphQLError: Fragment cannot be spread here as objects of type 'Me' can never be of type 'User'., are currently being logged as GraphQL internal server error in Sentry.

Root Cause

The error_formatter in apps/codecov-api/graphql_api/views.py was not correctly distinguishing between actual server-side exceptions and client-side GraphQL validation errors. When a GraphQL query fails validation (e.g., due to an invalid fragment spread or unknown field), the error.original_error attribute is None. The existing logic would then fall into a generic else block, logging these client-caused issues as internal server errors to Sentry.

Solution

Modified the error_formatter to explicitly check for error.original_error is None. If this condition is met, it indicates a GraphQL validation error originating from a malformed client query. In such cases, the formatted error is now returned directly, preventing it from being logged as an internal server error or captured by Sentry. This ensures that Sentry alerts are reserved for genuine server-side issues.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes API-E91

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Jun 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (508927b) to head (d560d1a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files        1318     1318           
  Lines       50711    50713    +2     
  Branches     1625     1625           
=======================================
+ Hits        46604    46606    +2     
  Misses       3801     3801           
  Partials      306      306           
Flag Coverage Δ
apiunit 94.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants