fix(glk): apply recall sensitivity ceiling to contradiction hunt#20
Conversation
|
Thank you for your contribution to MOOTx01. Before it can be merged we need you to sign our Contributor License Agreement. You can read it here: CLA.md. To sign, post a comment on this pull request with exactly the following text: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e17efc022
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| guard a.adjectiveSensitivity.rawValue <= AdjectiveSensitivity.elevated.rawValue, | ||
| b.adjectiveSensitivity.rawValue <= AdjectiveSensitivity.elevated.rawValue |
There was a problem hiding this comment.
Compare raw sensitivity bits before screening
This guard decodes through Drawer.adjectiveSensitivity before comparing, but that accessor falls back to .normal for any unrecognized 6-bit sensitivity value, whereas BitmapEvaluator's default .sensitivityAtMost(.elevated) compares the raw field. If an estate contains a future-version/imported/corrupt row with sensitivity bits above 16 but not one of the current enum cases, it passes this check and can still be screened or echoed in borderline snippets, violating the intended default ceiling. Compare the raw extracted sensitivity bits instead, and apply the same fix to the Rust mirror.
Useful? React with 👍 / 👎.
Motivation
Description
.sensitivityAtMost(.elevated)) before content screening/snippet generation in the Swift hunt loop inContradictionHunt.swift.coordinator.rsso chunk→drawer-mapped candidates are skipped when aboveElevated.ContradictionHuntTests.swift) and Rust (coordinator.rstests) that capture a Secret drawer paired with a Normal drawer and assert the hunt returns no proposals, no borderline snippets, and counts zero screened pairs.Testing
cargo test --manifest-path packages/kits/GeniusLocusKit/rust/Cargo.toml hunt_protected_candidates_are_excluded_by_default_ceiling, but dependency resolution failed due to external network/GitHub access (crates.io index fetch →CONNECT tunnel failed, response 403).cargo test --offline ...) failed because required crateserde_jsonwas not available in the offline cache.swift test --package-path packages/kits/GeniusLocusKit --filter ContradictionHuntTests/protectedCandidatesAreExcludedByDefaultCeiling, but SwiftPM dependency fetches failed due to blocked GitHub access (CONNECT tunnel failed, response 403).Codex Task