implement a configurable superivision tree#48
Open
BrendanBall wants to merge 2 commits intocodedge-llc:masterfrom
Open
implement a configurable superivision tree#48BrendanBall wants to merge 2 commits intocodedge-llc:masterfrom
BrendanBall wants to merge 2 commits intocodedge-llc:masterfrom
Conversation
added 2 commits
December 23, 2021 08:18
Currently Kadabra starts an application which is problematic in some failure scenarios that can result in the entire BEAM node being restarted. Starting an application in a library doesn't put the library user in control. This fixes it in a backwards compatible way by allowing the library user to decide exactly how their application should behave when Kadabra crashes.
It's not possible to include the Application in a release without starting it automatically.
|
Hi @hpopp. Could this PR get a review? |
If any changes are needed I am happy to take over. I'm picking up the project that BrendanBall was working on |
|
Hey @David-Tennant, what was your solution in the meantime? Did you publish a fork? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Kadabra starts an application which is problematic
in some failure scenarios that can result in the entire BEAM node
being restarted.
Starting an application in a library doesn't put the library user in control.
This fixes it in a backwards compatible way by allowing the library user
to decide exactly how their application should behave when Kadabra
crashes.
This is related to codedge-llc/pigeon#200