Skip to content

fix(epub): 修复部分 EPUB 丢失样式的问题（HTML 未链接任何 CSS 时兜底注入 manifest 样式） #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codedogQBY merged 1 commit into from
Aug 10, 2026
+85 −54
Merged

fix(epub): 修复部分 EPUB 丢失样式的问题（HTML 未链接任何 CSS 时兜底注入 manifest 样式） #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 61 additions & 54 deletions packages/app-expo/assets/reader/reader.html
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions packages/foliate-js/epub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,6 +1109,13 @@ class Loader {
el.setAttribute(attr, await this.loadHref(el.getAttribute(attr), href, parents));
const replaceSrcset = async (el, attr) =>
el.setAttribute(attr, await this.replaceSrcset(el.getAttribute(attr), href, parents));
// remember whether the document originally linked any external
// stylesheet; used below for the malformed-book fallback
const stylesheetHrefs = new Set(
Array.from(doc.querySelectorAll('link[rel~="stylesheet" i]'), (el) =>
el.getAttribute("href"),
),
);
for (const el of doc.querySelectorAll("link[href]")) await replace(el, "href");
for (const el of doc.querySelectorAll("[src]")) await replace(el, "src");
for (const el of doc.querySelectorAll("[srcset]")) await replaceSrcset(el, "srcset");
Expand All @@ -1131,6 +1138,23 @@ class Loader {
if (el.textContent) el.textContent = await this.replaceCSS(el.textContent, href, parents);
for (const el of doc.querySelectorAll("[style]"))
el.setAttribute("style", await this.replaceCSS(el.getAttribute("style"), href, parents));
// Malformed-book fallback: if the document has no <link rel="stylesheet">
// at all, inject every CSS file declared in the package manifest (in
// manifest order) so the book's styling is still applied.
if (stylesheetHrefs.size === 0) {
const head = doc.head;
if (head) {
for (const cssItem of this.manifest) {
if (cssItem.mediaType !== MIME.CSS) continue;
const url = await this.loadItem(cssItem, parents.concat(href));
if (!url) continue;
const link = doc.createElementNS(NS.XHTML, "link");
link.rel = "stylesheet";
link.href = url;
head.appendChild(link);
}
}
}
// TODO: replace inline scripts? probably not worth the trouble
const result = new XMLSerializer().serializeToString(doc);
return this.createURL(href, result, item.mediaType, parent);
Expand Down