Skip to content

fix navbar toggle button in mobile size #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ct-krisha wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix navbar toggle button in mobile size #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3336067
fix navbar toggle button in mobile size
ct-krisha May 5, 2026
7b82d84
PR review changes
ct-krisha May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/app/theme/layout/admin/admin.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,11 @@ export class AdminComponent {

// public method
navMobClick() {
if (this.navCollapsedMob && !document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
this.navCollapsedMob = !this.navCollapsedMob;
setTimeout(() => {
this.navCollapsedMob = !this.navCollapsedMob;
}, 100);
if (this.navCollapsedMob) {
document.querySelector('app-navigation.pcoded-navbar')?.classList.add('mob-open');
} else {
this.navCollapsedMob = !this.navCollapsedMob;
document.querySelector('app-navigation.pcoded-navbar')?.classList.remove('mob-open');
}
}

Expand All @@ -48,8 +46,7 @@ export class AdminComponent {
}

closeMenu() {
if (document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
document.querySelector('app-navigation.pcoded-navbar').classList.remove('mob-open');
}
this.navCollapsedMob = false;
document.querySelector('app-navigation.pcoded-navbar')?.classList.remove('mob-open');
}
}
18 changes: 14 additions & 4 deletions src/app/theme/layout/admin/nav-bar/nav-bar.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// angular import
import { Component, output } from '@angular/core';
import { Component, Output, EventEmitter, HostListener } from '@angular/core';
import { RouterModule } from '@angular/router';
import { CommonModule } from '@angular/common';

Expand All @@ -16,7 +16,7 @@ import { NavRightComponent } from './nav-right/nav-right.component';
})
export class NavBarComponent {
// public props
readonly NavCollapsedMob = output();
@Output() NavCollapsedMob = new EventEmitter<void>();
navCollapsedMob;
headerStyle: string;
menuClass: boolean;
Expand Down Expand Up @@ -45,8 +45,18 @@ export class NavBarComponent {
}

closeMenu() {
if (document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
document.querySelector('app-navigation.pcoded-navbar').classList.remove('mob-open');
if (document.querySelector('app-navigation.pcoded-navbar')?.classList.contains('mob-open')) {
this.NavCollapsedMob.emit();
}
}

@HostListener('document:click', ['$event'])
onDocumentClick(event: MouseEvent) {
const target = event.target as HTMLElement;
if (this.menuClass && !target.closest('#mobile-header') && !target.closest('.navbar-collapse')) {
this.menuClass = false;
this.headerStyle = '';
this.collapseStyle = 'none';
}
}
}
4 changes: 2 additions & 2 deletions src/app/theme/layout/admin/navigation/nav-content/nav-item/nav-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ export class NavItemComponent {
last_parent.classList.add('active');
}
}
if (document.querySelector('app-navigation.pcoded-navbar').classList.contains('mob-open')) {
document.querySelector('app-navigation.pcoded-navbar').classList.remove('mob-open');
if (document.querySelector('app-navigation.pcoded-navbar')?.classList.contains('mob-open')) {
document.getElementById('mobile-collapse1')?.click();
}
}
}