catherine-looper#5
Open
ccloops wants to merge 4 commits into
Open
Conversation
izzybaer
reviewed
Nov 28, 2017
| describe('arithmetic.test.js', () => { | ||
| describe('arithmetic.sum', () => { | ||
| test('does arithmetic.sum work properly', () => { | ||
| expect(arithmetic.sum('nine', 'one')).toBe(null); |
There was a problem hiding this comment.
it would also be a good idea for both add and sub to test for one argument as a number input and the other as non numeric input, one of each.
izzybaer
reviewed
Nov 28, 2017
| describe('greet.test.js', () => { | ||
| describe('greet.null', () => { | ||
| test('testing to return null for non string values', () => { | ||
| expect(greet.hello(null)).toBeNull(); |
There was a problem hiding this comment.
you should also be inputting an empty string, and returning null, and also testing for a numeric input and returning null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed Lab 01: Node Ecosystem