lab-david#12
Open
austriker27 wants to merge 42 commits into
Open
Conversation
…index file for new components, added cookie stuff, created client profile reducer and added header component for nav bar
izzybaer
reviewed
Jan 25, 2018
|
|
||
| const store = createStore(reducer, composeWithDevTools( | ||
| applyMiddleware(thunk), | ||
| )) |
izzybaer
reviewed
Jan 25, 2018
| value={this.state.username} | ||
| onChange={this.handleChange} | ||
| /> | ||
|
|
Contributor
There was a problem hiding this comment.
you need to be passing in signupRenderedJSX here {signupRenderedJSX}
izzybaer
reviewed
Jan 25, 2018
| @@ -0,0 +1,2 @@ | |||
| export default store => next => action => | |||
Contributor
There was a problem hiding this comment.
you need a redux-reporter.js here instead with a try catch that sets state
Author
There was a problem hiding this comment.
I removed the redux writer because we weren't using it.
izzybaer
reviewed
Jan 25, 2018
| console.log({response}); | ||
| return store.dispatch(setTokenAction(response.text)); | ||
| }); | ||
| }; |
Contributor
There was a problem hiding this comment.
it would be a good idea to add a .catch here since this isnt working
…scss modules, added some base css styles
…t work from app index
… to the dashboard
moving changes from file reader into full stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.