ref: extract makeScreen factory and clean up drop/toast handling#22
Merged
trmquang93 merged 1 commit intomainfrom Apr 3, 2026
Merged
ref: extract makeScreen factory and clean up drop/toast handling#22trmquang93 merged 1 commit intomainfrom
trmquang93 merged 1 commit intomainfrom
Conversation
- Extract makeScreen() factory to eliminate duplicated screen object literals across addScreen, addScreenAtCenter, addScreensBatch, and addStateVariant - Decouple handleCanvasDrop from DragEvent — accept files array directly - Broaden drop image filter to any image/* type (not just png/jpeg) - Add toast z-index constant and toastTimerRef cleanup on unmount - Replace hardcoded rgba with COLORS.accent008 in CanvasArea drop overlay - Default gridPositions rowGap to GRID_MARGIN instead of hardcoded 60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeScreen()factory function inuseScreenManager.jsto eliminate ~60 lines of duplicated screen object literals across 4 call siteshandleCanvasDropfromDragEvent— now accepts afilesarray directly, making it easier to test and reusepng/jpegonly to anyimage/*typeZ_INDEX.toastconstant andtoastTimerRefcleanup on unmountrgba(97,175,239,0.08)withCOLORS.accent008in drop overlaygridPositionsrowGaptoGRID_MARGINinstead of hardcoded60Test plan