Skip to content

test(metadata): cover metadata exclusion rules in split_metadata() - #257

Merged
Kaap10 merged 1 commit into
codeforstartups:developmentfrom
GITHUBTANMAY2003:test/issue-245-non-filterable-metadata
Sep 26, 2026
Merged

Kaap10 merged 1 commit into
codeforstartups:developmentfrom
GITHUBTANMAY2003:test/issue-245-non-filterable-metadata

Conversation

@GITHUBTANMAY2003

Copy link
Copy Markdown
Contributor

Description

Adds regression coverage for metadata exclusion behavior in split_metadata(). These tests ensure that non-filterable metadata is excluded from S3 Vectors while remaining available in DynamoDB, and that required namespace metadata is always preserved.

This is a test-only change; no production code was modified.

Related issue

Fixes #245

Changes

  • Added coverage verifying that non_filterable_keys are excluded from S3 metadata but retained in DynamoDB.
  • Added coverage verifying denylist precedence and mandatory namespace preservation.
  • Added coverage verifying that split_metadata() does not mutate caller-provided metadata.

Testing

  • Tests pass locally
  • Ruff checks pass
  • Documentation updated, if applicable

Verification performed:

  • Four focused regression tests: 4 passed
  • Complete metadata test module: 29 passed
  • Full offline test suite: passed
  • make run-ci: passed
  • Tests verified without live AWS credentials
  • Two live-AWS tests skipped as expected

Checklist

  • My changes are focused and relevant to this pull request.
  • I have added or updated tests where appropriate.
  • I have reviewed my changes for unrelated modifications.
  • I have updated documentation where necessary.

@Kaap10 Kaap10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent work @GITHUBTANMAY2003. All 4 metadata exclusion test scenarios are cleanly covered and tested offline.

@Kaap10
Kaap10 merged commit 2999134 into codeforstartups:development Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(metadata): Cover metadata exclusion rules in split_metadata()

2 participants