test(metadata): cover metadata exclusion rules in split_metadata() - #257
Merged
Kaap10 merged 1 commit intoSep 26, 2026
Conversation
Kaap10
approved these changes
Sep 26, 2026
Kaap10
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Excellent work @GITHUBTANMAY2003. All 4 metadata exclusion test scenarios are cleanly covered and tested offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression coverage for metadata exclusion behavior in
split_metadata(). These tests ensure that non-filterable metadata is excluded from S3 Vectors while remaining available in DynamoDB, and that required namespace metadata is always preserved.This is a test-only change; no production code was modified.
Related issue
Fixes #245
Changes
non_filterable_keysare excluded from S3 metadata but retained in DynamoDB.split_metadata()does not mutate caller-provided metadata.Testing
Verification performed:
4 passed29 passedmake run-ci: passedChecklist