perf(s3vectors): parallelize put_vectors across batches using ThreadP… - #259
Merged
Kaap10 merged 2 commits intoSep 26, 2026
Merged
Conversation
Contributor
Author
|
I've submitted a pull request for this issue: #259. All CI checks are passing |
Kaap10
approved these changes
Sep 26, 2026
Kaap10
approved these changes
Sep 26, 2026
Kaap10
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Clean implementation of batch parallelization using ThreadPoolExecutor with proper exception propagation and throughput unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallelized batch execution in
S3VectorsStore.put_vectorsusingThreadPoolExecutorto speed up large vector ingestions while preserving error propagation.Related issue
Fixes #13
Changes
ThreadPoolExecutorwith worker count bounded by batch count (min(max_workers, len(chunks))).as_completedandfuture.result()to ensure exceptions in any worker thread are re-raised immediately.tests/test_s3vectors.py.Testing
Checklist