You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we also update CLIRequest::parseCommand() to handle the -- separator the same way? Right now it still uses the old logic, so service('request')->getOptions() will treat --flag after -- as an option.
Should we also update CLIRequest::parseCommand() to handle the -- separator the same way? Right now it still uses the old logic, so service('request')->getOptions() will treat --flag after -- as an option.
Okay, I can do that. But that would also mean we would have two places doing exactly the same thing. I'm thinking to update CLIRequest and have CLI call it. What do you think?
Okay, I can do that. But that would also mean we would have two places doing exactly the same thing. I'm thinking to update CLIRequest and have CLI call it. What do you think?
Hmm... I agree we should avoid duplicating the parsing logic, but I'm not sure having CLI call CLIRequest is the best direction. CLI is the smaller utility, while CLIRequest is a heavier request object, so that dependency feels a bit backwards. I think it would be cleaner to extract the parsing into a small shared helper and let both CLI and CLIRequest use it.
Hmm... I agree we should avoid duplicating the parsing logic, but I'm not sure having CLI call CLIRequest is the best direction. CLI is the smaller utility, while CLIRequest is a heavier request object, so that dependency feels a bit backwards. I think it would be cleaner to extract the parsing into a small shared helper and let both CLI and CLIRequest use it.
I was previously thinking CLIRequest to call CLI but realized CLI is static so any changes to it will be persisted. Ok, I will go with a helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for POSIX
--delimiter to mean the end of options.Checklist: