Skip to content

fix: prevent session_start() lock errors with Memcached handler #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jalexiscv wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: prevent session_start() lock errors with Memcached handler #10209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions system/Session/Handlers/MemcachedHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ public function close(): bool
if (isset($this->memcached)) {
if (isset($this->lockKey)) {
$this->memcached->delete($this->lockKey);
$this->lockKey = null;
$this->lock = false;
}

return true;
Expand Down
5 changes: 4 additions & 1 deletion system/Session/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,10 @@ protected function startSession()
return;
}

session_start(); // @codeCoverageIgnore
// Error suppression is used to prevent warnings when
// concurrent requests cause session lock conflicts.
// This is a known PHP limitation with custom session handlers.
@session_start(); // @codeCoverageIgnore
}

/**
Expand Down