refactor: Query Builder WHERE/HAVING condition handling#10217
Open
memleakd wants to merge 1 commit into
Open
Conversation
- Route WHERE/HAVING condition insertion through shared prefix handling - Extract WHERE/HAVING condition compilation into focused private helpers - Add regression coverage for operator and null condition handling - Reduce the BaseBuilder empty() PHPStan baseline count Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes refactoring the internal Query Builder handling for
WHEREandHAVINGconditions without changing public APIs or expected SQL output.The existing condition-building paths each handled parts of prefixing, grouping, and compilation themselves. This centralizes those pieces into small private helpers so the behavior is easier to follow and safer to maintain.
It also adds regression coverage for a few important condition cases:
LIKEwith a bound value= nullcompiling toIS NULL!= nullcompiling toIS NOT NULLThis is intentionally a behavior-preserving cleanup. No new user-facing API is added, so there is no user guide or changelog entry.
Checklist: