Repository navigation
feat: handle Ctrl+C and Ctrl+Break in SignalTrait on Windows - #10699
Open
mdalikadar wants to merge 4 commits into
Open
mdalikadar wants to merge 4 commits into
mdalikadar wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Windows support to
SignalTrait, as discussed in #10589. Without PCNTL,registerSignals()now installs a console control handler throughsapi_windows_set_ctrl_handler(). It is reported to the command asSIGINT(2), because theSIG*constants come from PCNTL and are not available on Windows. A command can then stop gracefully on Ctrl+C or Ctrl+Break throughshouldTerminate(),onInterruption()or a mapped method, as it does on Unix.unregisterSignals()removes the handler.getSignalName()no longer touches theSIG*constants without PCNTL, sogetProcessState()works there.withSignalsBlocked()stays a no-op on Windows, which is documented.Refs #10589
Checklist: