Make inline and footer links open in a new tab#87
Closed
meldra wants to merge 1 commit intocodemeta:masterfrom
Closed
Make inline and footer links open in a new tab#87meldra wants to merge 1 commit intocodemeta:masterfrom
meldra wants to merge 1 commit intocodemeta:masterfrom
Conversation
When the generator is included in an iframe, such as requested in codemeta.github.io#84 and implemented in codemeta.github.io#89 clicking the links will attempt and fail to load in the iframe because of CORS which doesn't affect the generator due to deployment within the same domain.
Member
|
Er, why include it in an iframe instead of linking to it? |
Member
|
(let's discuss that on codemeta/codemeta.github.io#89 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the generator is included in an iframe, such as requested in codemeta.github.io#84 and implemented in codemeta.github.io#89 clicking the links will attempt and fail to load in the iframe because of CORS which doesn't affect the generator due to deployment within the same domain.