Skip to content

setup: upgrade#22

Merged
alexbit-codemod merged 3 commits into
codemod:mainfrom
AugustinMauroy:upgrade
May 15, 2026
Merged

setup: upgrade#22
alexbit-codemod merged 3 commits into
codemod:mainfrom
AugustinMauroy:upgrade

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Contributor

description

The idea for this repo is to be production ready but they are missing part.

  • add ci to lint + type check that run on ubuntu-slim which is the quickest CI runner and lighter. by default it's have node LTS installed so no need to setup node 🎉
  • add ci to run tests on codemod congras to Jacob for this script
  • update package.json according to these changes
  • remove useless gitkeep

@AugustinMauroy
Copy link
Copy Markdown
Contributor Author

cc @mohebifar @alexbit-codemod

Copy link
Copy Markdown
Contributor

@mohab-sameh mohab-sameh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few regressions I hit locally.

Comment thread .github/workflows/code-quality.yml Outdated
Comment thread .github/workflows/code-quality.yml Outdated
Comment thread .github/workflows/code-quality.yml Outdated
Comment thread biome.jsonc Outdated
@AugustinMauroy
Copy link
Copy Markdown
Contributor Author

oh noice you just pushed code !

@alexbit-codemod
Copy link
Copy Markdown
Contributor

thanks.

note to self for future improvements, drawing inspiration from https://github.com/codemod/datadog-codemods/

Versioning and releases (biggest operational gap)

  • Changesets for semver bumps and release notes discipline.
  • version-packages runs scripts/sync-codemod-versions.sh so codemod.yaml version tracks package.json (template leaves versions manual per package / publish flow).
  • Release workflow: consume changesets → commit “Version Packages” → tag → matrix publish with codemod/publish-action.
  • Changeset check on PRs, with a skip-changeset label escape hatch.
  • Manual publish workflow with a path under codemods/.
  • Template’s publish story is tag-driven (@v) with a search codemod.yaml by name+version step— workable, but not tied to an enforced changeset → version bump loop.

Contributor docs should be aimed at “don’t mess up releases”. AGENTS.md should be short and center on failure modes (forgetting changesets, hand-editing versions, skipping pnpm run ci).
This Migration Template AGENTS.md is long and more tutorial (MCP, CODEMOD-TEMPLATE.md, full workflow nodes)
Any instructions users need to build codemods should be in the MCP (which is always kept fresh)

CI design

  • PRs: format/lint only changed files; tests + check-types only for touched codemod packages; markdown link check (docs:links); changeset enforcement.
  • Push to main: full pnpm run ci (all filtered workspace packages).
  • Concurrency (cancel-in-progress) on workflows.

Local automation (developer experience)

  • Husky + lint-staged (.lintstagedrc.mjs): format/lint staged files; codemods/**/scripts/*.ts runs scripts/test-staged.sh so edits to transforms get a quick test pass before commit.
  • Template has no pre-commit hook in the tree you have.

@alexbit-codemod alexbit-codemod merged commit 8de7d4a into codemod:main May 15, 2026
3 of 4 checks passed
@AugustinMauroy AugustinMauroy deleted the upgrade branch May 15, 2026 08:02
@AugustinMauroy
Copy link
Copy Markdown
Contributor Author

commit hook isn't good idea. keep a pre-commit script that user will run. But commit hook can be annoying, when you create a WIP commit as a checkpoint of you thinking.

@mohab-sameh
Copy link
Copy Markdown
Contributor

commit hook isn't good idea. keep a pre-commit script that user will run. But commit hook can be annoying, when you create a WIP commit as a checkpoint of you thinking.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants