Skip to content

Add website-targeted JavaScript Skin Designer integration#4758

Open
liannacasper wants to merge 25 commits intomasterfrom
codex/build-javascript-version-of-skindesigner
Open

Add website-targeted JavaScript Skin Designer integration#4758
liannacasper wants to merge 25 commits intomasterfrom
codex/build-javascript-version-of-skindesigner

Conversation

@liannacasper
Copy link
Copy Markdown
Collaborator

Motivation

  • Provide a web-friendly JavaScript build of the existing Skin Designer so it can be embedded into the website similarly to the Playground and Initializr, and enable save/export flows in browser mode.

Description

  • Add a website-native ShouldExecute implementation for the JavaScript port that returns true and posts a cn1-skindesigner-ui-ready message to the parent page to support embedded hosting (file: scripts/skindesigner/javascript/src/main/javascript/com_codename1_tools_skindesigner_ShouldExecute.js).
  • Add a new site page and Hugo layout that embeds the JavaScript bundle at /skindesigner/ with loading UI and dark-mode sync (files: docs/website/content/skindesigner.md and docs/website/layouts/_default/skindesigner.html).
  • Add a Developers menu entry for "Skin Designer" in docs/website/hugo.toml.
  • Extend scripts/website/build.sh to optionally build and extract the Skin Designer JavaScript bundle into docs/website/static/skindesigner-app using WEBSITE_INCLUDE_SKINDESIGNER, following the same pattern used for Playground/Initializr.

Testing

  • Ran bash -n scripts/website/build.sh which reported no syntax errors in the modified build script.
  • Attempted to build the JavaScript module with sh ./mvnw -q -pl javascript -am -DskipTests -Dcodename1.platform=javascript package in scripts/skindesigner, but the build failed in this environment due to missing Java 8 (JAVA_HOME path not present) and network/maven wrapper download errors (java.net.SocketException: Network is unreachable).
  • Changes were committed and a branch/PR message was prepared; no further automated tests were executed due to the environment limitations described above.

Codex Task

@github-actions
Copy link
Copy Markdown
Contributor

Cloudflare Preview

Comment thread docs/website/layouts/_default/skindesigner.html Fixed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator

shai-almog commented Apr 17, 2026

JavaSE simulator screenshot updates

Compared 7 screenshots: 6 matched, 1 updated.

  • javase-single-test-recorder — updated screenshot. Screenshot differs (2200x1400 px, bit depth 8).

    javase-single-test-recorder
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 1540x980.
    Full-resolution PNG saved as javase-single-test-recorder.png in workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants