Skip to content

JavaScript port: touch long press menu and resize white flash - #6111

Merged
shai-almog merged 1 commit into
masterfrom
js-touch-contextmenu-page-background
Oct 26, 2026
Merged

shai-almog merged 1 commit into
masterfrom
js-touch-contextmenu-page-background

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

Fixes #6108, fixes #6109.

🤖 Generated with Claude Code

… follows the form

Fixes #6108: Android Chrome fires contextmenu for a touch long press, which
opened CN1's right-click menu whenever the press landed on the canvas.
Fixes #6109: the page behind the canvas takes the form's opaque plain
background on form show and canvas resize, so resizes no longer flash white.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare Preview

@shai-almog

shai-almog commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 227 screenshots: 227 matched.
✅ JavaScript-port screenshot tests passed.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ✅ ByteCodeTranslator: 0 findings (no issues)
    • ✅ android: 0 findings (no issues)
    • ✅ android-compat: 0 findings (no issues)
    • ✅ android-res-compiler: 0 findings (no issues)
    • ✅ backend: 0 findings (no issues)
    • ✅ backend-test: 0 findings (no issues)
    • ✅ build-engine: 0 findings (no issues)
    • ✅ build-hint-catalog: 0 findings (no issues)
    • ✅ build-hint-tools: 0 findings (no issues)
    • ✅ codenameone-gradle-plugin: 0 findings (no issues)
    • ✅ codenameone-maven-plugin: 0 findings (no issues)
    • ✅ core-unittests: 0 findings (no issues)
    • ✅ desktop-compat-runtime: 0 findings (no issues)
    • ✅ fxml-compiler: 0 findings (no issues)
    • ✅ ios: 0 findings (no issues)
    • ✅ javac: 0 findings (no issues)
    • ✅ javafx-compat: 0 findings (no issues)
    • ✅ project-model: 0 findings (no issues)
    • ✅ swing-compat: 0 findings (no issues)
  • ✅ PMD: 0 findings (no issues) [Report archive]
  • ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@github-actions

Copy link
Copy Markdown
Contributor

✅ ByteCodeTranslator Quality Report

Test & Coverage

  • ✅ Tests: 881 total, 0 failed, 55 skipped

Benchmark Results

  • Execution Time: 8953 ms

  • Hotspots (Top 20 sampled methods):

    • 8.68% com.codename1.tools.translator.IteratorEscape.ctorOnlyStoresParamsIntoThis (122 samples)
    • 8.68% java.lang.Object.hashCode (122 samples)
    • 7.47% java.lang.System.identityHashCode (105 samples)
    • 6.76% java.util.ArrayList.indexOf (95 samples)
    • 5.69% com.codename1.tools.translator.BytecodeMethod.equals (80 samples)
    • 3.34% com.codename1.tools.translator.IteratorEscape.mangle (47 samples)
    • 2.70% java.lang.StringBuilder.append (38 samples)
    • 1.99% com.codename1.tools.translator.BytecodeMethod.updateInlinableFieldDependencies (28 samples)
    • 1.64% java.util.AbstractCollection.containsAll (23 samples)
    • 1.56% java.lang.String.equals (22 samples)
    • 1.49% com.codename1.tools.translator.IteratorEscape.walk (21 samples)
    • 1.42% com.codename1.tools.translator.Parser.cullMethods (20 samples)
    • 1.35% com.codename1.tools.translator.JavascriptReachability.enqueueResolved (19 samples)
    • 1.35% com.codename1.tools.translator.ByteCodeClass.hasDeclaredMethod (19 samples)
    • 1.28% com.codename1.tools.translator.classfile.analysis.Frame.execute (18 samples)
    • 1.14% com.codename1.tools.translator.ReachabilityCull.run (16 samples)
    • 1.14% com.codename1.tools.translator.bytecodes.Invoke.resolveDirectTarget (16 samples)
    • 1.14% java.util.HashMap.hash (16 samples)
    • 1.07% java.util.HashMap.putVal (15 samples)
    • 1.07% com.codename1.tools.translator.bytecodes.Invoke.findMethodUp (15 samples)
  • ⚠️ Coverage report not generated.

Static Analysis

  • ✅ SpotBugs: no findings (report was not generated by the build).
  • ⚠️ PMD report not generated.
  • ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

@shai-almog
shai-almog merged commit 495f849 into master Oct 26, 2026
63 of 67 checks passed
@shai-almog
shai-almog deleted the js-touch-contextmenu-page-background branch October 26, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant