Repository navigation
Release 7.0.280 blockers: backend writer close order, x64 Linux native swap - #6135
Merged
Merged
Conversation
A bodiless streamed response (HEAD, 204, 304) wrote its head first and closed the writer afterwards, so a client could act on the response while the writer still held its resources. HttpStreamingTest's aWriterTheServerNeverRunsIsClosed lost that race on master CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The x64 leg ran out of memory compiling the grown hello suite, the same failure arm64 already had swap for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while checking master is ready for 7.0.280.
Backend: close a never-run body writer before the HTTP/1 head. On master, PR CI failed in
HttpStreamingTest.aWriterTheServerNeverRunsIsClosed. A HEAD, 204, 205 or 304 response whose handler sets a streamingBodyWriterwrote its head first and only then closed the writer. A client could read the status and move on before the close happened. The writer is now closed first, which is the order HTTP/2 already uses. Because that backend test failed, the build stopped before the static-analysis modules, so this PR's CI is also the first SpotBugs and PMD run over everything merged since 7.0.279.CI: swap on the x64 Linux native suite. Since #6118 and #6106 made the hello suite bigger, every
build + run suite (x64)run has gone silent incmake --build. About an hour in, the runner is shut down. arm64 hit the same thing earlier and has had a swapfile for it; x64 now gets one too, plus adfline. Memory exhaustion is inferred rather than shown in any log: if the job still dies with swap in place, the next step is to cap build parallelism.🤖 Generated with Claude Code