fix(log): remove duplicate pushcli in log_write#359
Open
himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
Open
fix(log): remove duplicate pushcli in log_write#359himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
Conversation
log_write called pushcli() twice but popcli() only once, so every FS write leaked one cli depth and left interrupts disabled after the caller's matching popcli. Drop the redundant second pushcli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
log_writeinlog.ccallspushcli()twice butpopcli()only once.Fix
Drop the duplicate
pushcli()so the function has balancedpushcli()/popcli().