fix(mmu): remove duplicate NSEGS definition#360
Open
himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
Open
fix(mmu): remove duplicate NSEGS definition#360himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
himanshi1505 wants to merge 1 commit intocodenet:p28-killfrom
Conversation
NSEGS and its accompanying comment were defined twice in mmu.h (once near the segment-selector block, once again below the STA_* flags). Drop the second copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mmu.hdefinedNSEGS(and the same leading comment) twice —once near the
SEG_*selector block and again after theSTA_*bits.
Fix
Remove the second copy of the comment +
#define NSEGS 6.