Add fsync binary to clean target in 05/Makefile in main branch#371
Open
manvendrarajpurohit wants to merge 1 commit intocodenet:mainfrom
Open
Add fsync binary to clean target in 05/Makefile in main branch#371manvendrarajpurohit wants to merge 1 commit intocodenet:mainfrom
manvendrarajpurohit wants to merge 1 commit intocodenet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes make clean in 05/Makefile so it removes all binaries produced by make all (both io and fsync), preventing stale executables from being left in the working tree.
Changes:
- Update the
cleantarget to remove thefsyncbinary in addition toio.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The all target builds two binaries — io and fsync — but the clean target only removes io. After running
makeand thenmake clean, the fsync executable is left behind in the working tree.Added fsync to the rm -f line so clean removes both binaries.