Skip to content

fix(strategy): treat opened pack cost as sunk, not refundable - #83

Open
BGarber42 wants to merge 1 commit into
coder:mainfrom
BGarber42:fix/pack-open-sunk-cost
Open

fix(strategy): treat opened pack cost as sunk, not refundable#83
BGarber42 wants to merge 1 commit into
coder:mainfrom
BGarber42:fix/pack-open-sunk-cost

Conversation

@BGarber42

Copy link
Copy Markdown

Summary

  • Teach all strategies that after buying a booster, the cost is already spent — skipping does not refund money, so prefer taking upside unless there is a skip-payoff joker (e.g. Red Card) or every option is actively harmful.
  • Fix pack card modifier rendering to use card.modifier.* so Standard packs show enhancement/edition/seal to the LLM.
  • Add unit tests covering sunk-cost guidance and modifier rendering across default/conservative/aggressive.

Test plan

  • Run uv run pytest tests/unit/test_strategy.py::TestPackOpenSunkCostGuidance tests/unit/test_strategy.py::TestRenderPackPlayingCardModifiers -v
  • Spot-check a shop run: buy a pack, confirm prompts discourage skip-for-savings reasoning

Skipping after buy does not refund money; prefer taking upside unless skip payoff or all options are harmful. Also render pack card modifiers from card.modifier so Standard packs show enhancements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant