Repository navigation
fix: only fill in session tokens for known Coder IDE links - #188
Merged
Merged
Conversation
untra
reviewed
Oct 30, 2026
untra
reviewed
Oct 30, 2026
untra
reviewed
Oct 30, 2026
EhabY
force-pushed
the
fix/trusted-app-links
branch
from
October 30, 2026 15:50
bcd53c3 to
fa16fbb
Compare
untra
approved these changes
Oct 30, 2026
- Add ISettingsManager.Update, which reads, changes and writes under one lock, so saving a trusted scheme can't race with another update. - Await the confirmation flyout's choice so one command run covers the whole flow and can't stack a second flyout. - Add a Settings button that clears the trusted schemes. - Shorten the message shown for untrusted links.
EhabY
force-pushed
the
fix/trusted-app-links
branch
from
October 30, 2026 16:09
fa16fbb to
5cc728a
Compare
untra
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External app links now follow the same
$SESSION_TOKENrules as the dashboard (coder/coder#31208).urlparam is the sign-in URL or the deployment'sdashboard_urlfrom build info, and the placeholder is thetokenvalue.app-link-settings.json.parent_idfrom the workspace agent anddashboard_urlfrom build info.Decision log
dashboard_urlkept in memory, not saved: an admin can change the access URL, so it's fetched again on each launch and sign-in.ContentDialog's minimum width.LauncherOptions.TreatAsUntrustedis ignored in desktop apps.AppLinkSettingsthrough the existingSettingsManager<T>, separate from the Coder Connect settings. A corrupt file shows the usual "Could not open app" error, like the Coder Connect settings.Uri.OriginalString:Uri.ToString()unescapes the link. The click checks again with the credentials whose token it uses.Tests: CI build, fmt and test pass. The tray UI wasn't run by hand.