Skip to content

upgrade runtime to dotnet 10 - #189

Merged
untra merged 18 commits into
mainfrom
fix/update-dotnet-10
Oct 29, 2026
Merged

untra merged 18 commits into
mainfrom
fix/update-dotnet-10

Conversation

@untra

@untra untra commented Oct 28, 2026

Copy link
Copy Markdown
Contributor
  • upgrade / overhaul to use dotnet 10
  • installs 10.0.14 dotnet runtime, uses dotnet 10 build sdk
  • aggressively disallow crlf
  • updates some test dependencies

@jeremyruppel

Copy link
Copy Markdown

The 10 packages.lock.json files are committed with CRLF line endings, which contradicts the new * text=auto eol=lf rule in .gitattributes (they're LF on main). Running this on the branch fixes them:

git add --renormalize .
git commit -m "chore: renormalize lockfile line endings"

It also shrinks the diff from about 2,800 changed lines to about 835, which makes it much easier to review.


Generated by Coder Agents on behalf of @jeremyruppel.

Comment thread Vpn.Service/Downloader.cs
}
}
}
using System.Collections.Concurrent;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this another CRLF file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually added carriage returns in #186 while working from windows , because I was confident and foolish, and perhaps meat proxiful. 😞
this correctly fixes that.

Comment thread .gitattributes Outdated
@@ -1 +1,2 @@
MutagenSdk/Proto/**/*.proto linguist-generated=true
* text=auto eol=lf No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a trailing newline

Comment thread .gitattributes
@@ -1 +1,2 @@
MutagenSdk/Proto/**/*.proto linguist-generated=true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we should mark **/packages.lock.json as linguist-generated=true

Comment thread global.json Outdated
"version": "10.0.100",
"rollForward": "latestFeature"
}
} No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a trailing newline

"net8.0": {}
"net10.0": {}
}
} No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. this is generated? but missing a trailing new line, but it's the only one of these lock files that's missing it..

@untra
untra requested a review from deansheather October 29, 2026 17:50

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple last small things but seems good 👍

Comment thread scripts/Publish.ps1 Resolved
Comment thread scripts/Publish.ps1 Resolved
@untra
untra marked this pull request as ready for review October 29, 2026 19:55
Co-authored-by: McKayla はな  <kayla@tree.camp>
@untra
untra merged commit d7d6846 into main Oct 29, 2026
3 checks passed
@untra
untra deleted the fix/update-dotnet-10 branch October 29, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants