Repository navigation
fix: stop the tray crashing when an agent has more than 6 apps - #191
Merged
Merged
Conversation
VisibleApps returned the live Apps collection for up to 6 apps and a Take() copy above that. Each Apps change re-raised VisibleApps, so adding the 7th app swapped the ItemsRepeater's ItemsSource while Apps was still raising CollectionChanged. Apps then invoked the handler of the released ItemsSourceView and crashed the process. Keep VisibleApps as its own collection, synced with the first 6 apps, so the ItemsSource never changes.
untra
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VisibleAppsreturned the liveAppscollection for up to 6 apps and aTake()copy above that. Adding the 7th app swapped theItemsRepeater'sItemsSourcewhileAppswas still raisingCollectionChanged. That called the releasedItemsSourceView's handler and crashed the app on Coder Connect start.VisibleAppsis now a fixed collection that stays in sync with the first 6 apps, so theItemsSourcenever changes.Tested with a Release build against a workspace with 7 apps: starting Coder Connect crashed every time before this change and no longer does.
Related: #190
🤖 Generated with Claude Code