fix(providers/anthropic): serialize Bedrock system as string#28
Open
ibetitsmike wants to merge 1 commit intocoder_2_33from
Open
fix(providers/anthropic): serialize Bedrock system as string#28ibetitsmike wants to merge 1 commit intocoder_2_33from
ibetitsmike wants to merge 1 commit intocoder_2_33from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For Bedrock, fantasy was serializing
systemas an Anthropic-style array of text blocks:Bedrock's Anthropic Messages schema expects
systemas a plain string, so this triggers a 400 validationException on affected paths.Fix
Bedrock-only, post-serialization override:
prepareParamsstill produces the usual Anthropic params. WhenuseBedrockis set, it now also returns a flattened system string and leavesparams.Systemnil.buildRequestOptionsaccepts the override and applies it viaoption.WithJSONSet("system", flattened).GenerateandStreamgo through the same seam, so the wire shape cannot drift between streaming and non-streaming.flattenSystemForBedrockinproviders/anthropic/bedrock.gojoins non-empty text blocks with\n\n, preserving the existingtoPrompt/groupIntoBlockssemantics.Direct Anthropic behavior is unchanged and locked in by a new assertion.
Tests
TestBedrockSystemPromptWireShapecoversGenerateandStreamacross:\n\nin ordersystem, user, systempreserving only the first contiguous system block (matches today'stoPromptbehavior)systemas an arrayRecorded shapes:
{"system":[{"text":"you are helpful","type":"text"}]}{"system":"you are helpful"}{"system":[{"text":"you are helpful","type":"text"}]}Scope
No changes to
groupIntoBlocks,toPrompt, or any non-Bedrock path. No changes toproviders/bedrock/*.