Enable linefeed mode so newline moves cursor to column 0 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a terminal display issue where newline characters (\n) don't properly return the cursor to column 0, causing text to display in a staggered pattern. The fix enables linefeed mode when creating new terminal instances in the WASM API.
Key Changes:
- Enable linefeed mode by setting
wrapper.terminal.modes.set(.linefeed, true)after terminal initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Without linefeed mode enabled, \n only moves the cursor down without returning to column 0. This causes text to display in a staggered pattern instead of properly aligned at the left margin. This fix sets the linefeed terminal mode to true when creating a new terminal instance, making \n behave as expected (LF + CR).
remorses
force-pushed
the
fix/enable-linefeed-mode
branch
from
86ebd9c to
a95af7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
\nproperly moves cursor to column 0Problem
Without linefeed mode enabled,
\nonly moves the cursor down without returning to column 0. This causes text to display in a staggered pattern:Solution
Set
wrapper.terminal.modes.set(.linefeed, true)after terminal creation in the WASM API. This makes\nbehave as expected (LF + CR), properly returning the cursor to column 0: