Skip to content

fix: correct selection overflow during auto-scroll #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sreya merged 1 commit into from
Dec 4, 2025
Merged

fix: correct selection overflow during auto-scroll #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/selection-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,20 +705,19 @@ export class SelectionManager {
// Key insight: we need to EXTEND the selection, not reset it to viewport edge
if (this.selectionEnd) {
const dims = this.wasmTerm.getDimensions();
const viewportY = this.getViewportY();
if (this.autoScrollDirection < 0) {
// Scrolling up - extend selection upward (decrease absoluteRow)
// Set to top of viewport, but only if it extends the selection
const topOfViewport = viewportY;
if (topOfViewport < this.selectionEnd.absoluteRow) {
this.selectionEnd = { col: 0, absoluteRow: topOfViewport };
const topAbsoluteRow = this.viewportRowToAbsolute(0);
if (topAbsoluteRow < this.selectionEnd.absoluteRow) {
this.selectionEnd = { col: 0, absoluteRow: topAbsoluteRow };
}
} else {
// Scrolling down - extend selection downward (increase absoluteRow)
// Set to bottom of viewport, but only if it extends the selection
const bottomOfViewport = viewportY + dims.rows - 1;
if (bottomOfViewport > this.selectionEnd.absoluteRow) {
this.selectionEnd = { col: dims.cols - 1, absoluteRow: bottomOfViewport };
const bottomAbsoluteRow = this.viewportRowToAbsolute(dims.rows - 1);
if (bottomAbsoluteRow > this.selectionEnd.absoluteRow) {
this.selectionEnd = { col: dims.cols - 1, absoluteRow: bottomAbsoluteRow };
}
}
}
Expand Down