test: verify pixel-storybook#57 removes capture jitter - #1048
Draft
EhabY wants to merge 1 commit into
Draft
Conversation
EhabY
force-pushed
the
test/pixel-deterministic-capture
branch
from
July 28, 2026 18:40
9b68f05 to
60efcb3
Compare
Not for merge. Vendors a tarball built from coder/pixel-storybook@cc953b4 (coder/pixel-storybook#57, --disable-partial-raster) so the Pixel job can be re-run on this branch to check whether the 1/255 antialiasing jitter seen in builds #26 to #28 is gone. The tarball is vendored because coder/pixel-storybook is an internal repo and CI checkouts have no credentials to fetch a git dependency.
EhabY
force-pushed
the
test/pixel-deterministic-capture
branch
from
July 28, 2026 18:47
60efcb3 to
3815546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment, not for merge. Checks whether coder/pixel-storybook#57 (
--disable-partial-raster) removes the 1/255 antialiasing jitter seen in this project's Pixel builds #26 to #28.@coder/pixel-storybookpoints at a vendored tarball built fromcc953b4, the head of that PR. It is vendored rather than referenced as a git dependency becausecoder/pixel-storybookis internal and CI checkouts run without credentials.What to expect
Local runs over this project's 144 shots, 5 runs per arm:
The 4 unstable shots are
ui-searchinput--statesin light, dark, high-contrast and high-contrast-light: 9 to 11 pixels, max channel delta 1. Baseline churn measured locally: 0, so Pixel builds on this branch should report no changed snapshots.An earlier revision of this branch pinned a four-flag build and did produce churn: 4 changed
UI/Foundations/Tokensvariants, caused by--disable-skia-runtime-optsshifting hard gradient stop edges. That flag fixed no jitter and has been dropped from the PR.Method
Re-run the Pixel job several times on this commit. Every run should report zero changed snapshots. Any non-zero on an unchanged commit is residual jitter.
Generated by Coder Agents on behalf of @EhabY.