Skip to content

Add speedtest command#864

Merged
EhabY merged 2 commits intocoder:mainfrom
yazan-abu-obaideh:feat-750
Apr 7, 2026
Merged

Add speedtest command#864
EhabY merged 2 commits intocoder:mainfrom
yazan-abu-obaideh:feat-750

Conversation

@yazan-abu-obaideh
Copy link
Copy Markdown
Contributor

@yazan-abu-obaideh yazan-abu-obaideh commented Mar 27, 2026 •
edited
Loading

Closes #750

@EhabY EhabY self-requested a review March 29, 2026 11:27
EhabY
EhabY requested changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EhabY EhabY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this repo, appreciated ♥️

Also make sure to run format/lint:fix (I think the pipeline would fail now)

Comment thread src/core/cliUtils.ts Outdated
Comment thread test/fixtures/scripts/echo-args.bash Outdated
Comment thread src/commands.ts
Comment thread src/commands.ts Outdated
Comment thread src/core/cliUtils.ts Outdated
Comment thread src/commands.ts Outdated
Comment thread src/commands.ts Outdated
@yazan-abu-obaideh
Copy link
Copy Markdown
Contributor Author

yazan-abu-obaideh commented Apr 2, 2026

@EhabY happy to contribute 😉

(should pass now 🙏)

EhabY
EhabY reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EhabY EhabY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the tests! I think we'll have to await Asher's response for the UX but the rest are smaller issues!

Comment thread src/cliConfig.ts Outdated
Comment thread src/cliConfig.ts Outdated
Comment thread src/commands.ts Outdated
Comment thread src/commands.ts Outdated
Comment thread src/core/cliUtils.ts Outdated
Comment thread test/unit/core/cliUtils.test.ts
@yazan-abu-obaideh
feat: coder#750
b81afc6 
Add speed test command + tests. Runs the speedtest command through the Coder Cli and opens a json for the user to view.
@EhabY EhabY marked this pull request as ready for review April 5, 2026 19:13
EhabY
EhabY reviewed Apr 5, 2026
View reviewed changes
Comment thread src/api/authInterceptor.ts
Comment thread src/commands.ts Outdated
Comment thread src/commands.ts Outdated
Comment thread src/core/cliUtils.ts
binPath: string,
globalFlags: string[],
workspaceName: string,
options: { signal?: AbortSignal; duration?: string },
Copy link
Copy Markdown
Collaborator

@EhabY EhabY Apr 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love mixing two different kinds of options, one for args and one for the execution itself 🤔

Actually maybe inline this, it's very similar to the one in commands#openAppStatus. If we want to separate it out for testability then maybe we use a separate file for this? Something like core/cliExec.ts? (we'd move the version to it)

Comment thread src/commands.ts Outdated
Comment thread src/commands.ts Outdated
Comment thread src/commands.ts Outdated
@yazan-abu-obaideh
feat: coder#750
a2a407f 
Addressed review comments
EhabY
EhabY approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EhabY EhabY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks for the contribution, much appreciated!

@EhabY EhabY merged commit b199320 into coder:main Apr 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher left review comments

@EhabY EhabY EhabY approved these changes

Assignees

@yazan-abu-obaideh yazan-abu-obaideh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add command to run a coder speedtest against a workspace

3 participants

@yazan-abu-obaideh @EhabY @code-asher