Skip to content

Fix appName option and count billing events via dailyEvents#575

Merged
neSpecc merged 6 commits into
masterfrom
perf/mongo-optimizations
Jul 21, 2026
Merged

Fix appName option and count billing events via dailyEvents#575
neSpecc merged 6 commits into
masterfrom
perf/mongo-optimizations

Conversation

@Kuchizu

@Kuchizu Kuchizu commented Jul 3, 2026

Copy link
Copy Markdown
Member

Driver 3.x only accepts lowercase appname
Limiter now sums dailyEvents daily counters for full days and counts raw events/repetitions only for the partial day around lastChargeDate

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Mongo connection options for driver 3.x compatibility and refines limiter billing-period event counting by combining raw event scans for the “boundary day” with dailyEvents per-day counters for subsequent days.

Changes:

  • Switch Mongo connection option from appName to appname for MongoDB driver 3.x compatibility.
  • Update limiter DbHelper.getEventsCountByProject to count the partial boundary day via raw events/repetitions collections and sum later days via dailyEvents.
  • Expand limiter DB helper tests to cover dailyEvents-based counting and boundary-day filtering.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
workers/limiter/tests/index.test.ts Aligns mocked event timestamps with the boundary-day counting model.
workers/limiter/tests/dbHelper.test.ts Adds dailyEvents mocking and new tests for boundary-day vs dailyEvents counting behavior.
workers/limiter/src/dbHelper.ts Implements hybrid counting logic: raw scan for boundary day + aggregated dailyEvents for later days.
lib/db/controller.ts Uses lowercase appname Mongo option key for driver 3.x support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread workers/limiter/tests/dbHelper.test.ts
Comment thread workers/limiter/src/dbHelper.ts
Comment thread workers/limiter/src/dbHelper.ts Outdated
@Kuchizu
Kuchizu force-pushed the perf/mongo-optimizations branch from 68f49f6 to a7dcbb6 Compare July 8, 2026 08:32
Comment thread workers/limiter/src/index.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread workers/limiter/src/dbHelper.ts
Comment thread workers/limiter/src/dbHelper.ts
@neSpecc
neSpecc merged commit 50fc907 into master Jul 21, 2026
5 checks passed
@neSpecc
neSpecc deleted the perf/mongo-optimizations branch July 21, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants